SocketIO event filtering#50
Merged
Conversation
Member
Author
|
This is probably the biggest feature for the next release so we should make sure that this works nicely. /cc @Glavin001, @ekryski |
Contributor
|
This will be great! I'll try and test it out tomorrow. |
Member
Author
|
So #51 is based on this PR and implements the whole thing for Primus which I think should finalize this functionality. |
Member
Author
|
If there are no comments or concerns I'll merge this one and #51 in tonight so that we can get a 0.4.0 out this week. |
Contributor
|
👍 I looked over all of the changes and everything looked good. I have not had a chance to personal test it, but I didn't notice any missing Tests either and Travis CI is still happy. |
daffl
pushed a commit
that referenced
this pull request
Aug 19, 2018
* chore(package): update semistandard to version 11.0.0 https://greenkeeper.io/ * Fix for latest Semistandard
daffl
pushed a commit
that referenced
this pull request
Aug 21, 2018
* chore(package): update semistandard to version 11.0.0 https://greenkeeper.io/ * Fix for latest Semistandard
daffl
added a commit
that referenced
this pull request
Aug 21, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 21, 2018
daffl
added a commit
that referenced
this pull request
Aug 22, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 22, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 23, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 25, 2018
daffl
added a commit
that referenced
this pull request
Aug 28, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 28, 2018
daffl
added a commit
that referenced
this pull request
Aug 29, 2018
* Rename repository and use npm scope * Update debug dependency
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
daffl
added a commit
that referenced
this pull request
Aug 29, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
daffl
added a commit
that referenced
this pull request
Aug 29, 2018
* Rename repository and use npm scope * Update debug dependency
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request implements event filtering for SocketIO. Letting you filter events based on the connected client information. For example the following only dispatches the
updatedevent if the authorized user is in the same company than the updated todo:On the client:
Closes #44, closes #48.