Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Adding SocketIO handshake data to service call parameters#49

Merged
daffl merged 1 commit intomasterfeathersjs/feathers:masterfrom
socket-paramsfeathersjs/feathers:socket-paramsCopy head branch name to clipboard
Apr 3, 2014
Merged

Adding SocketIO handshake data to service call parameters#49
daffl merged 1 commit intomasterfeathersjs/feathers:masterfrom
socket-paramsfeathersjs/feathers:socket-paramsCopy head branch name to clipboard

Conversation

@daffl
Copy link
Member

@daffl daffl commented Apr 3, 2014

This is related to #44, #48 and #32 adding SocketIO handshake data as the service parameters like:

app.configure(feathers.socketio(function(io) {
  io.set('authorization', function (handshake, callback) {
    handshake.feathers.user = { name: 'David' };
  });
}));

With something like:

app.use('todos', {
  create: function(data, params, callback) {
    // When called via SocketIO:
    params.user // -> { name: 'David' }
  }
});

@daffl daffl added this to the 0.4.0 milestone Apr 3, 2014
@daffl daffl changed the title Adding SocketIO handshake data to service call parameters. Adding SocketIO handshake data to service call parameters Apr 3, 2014
@daffl daffl mentioned this pull request Apr 3, 2014
Closed
daffl added a commit that referenced this pull request Apr 3, 2014
@daffl
Merge pull request #49 from feathersjs/socket-params
04b3931 
Adding SocketIO handshake data to service call parameters
@daffl daffl merged commit 04b3931 into master Apr 3, 2014
@daffl daffl deleted the socket-params branch April 3, 2014 23:26
daffl pushed a commit that referenced this pull request Aug 19, 2018
@greenkeeper @daffl
Update dependencies to enable Greenkeeper 🌴 (#49)
edb4df7 
* chore(package): update dependencies

https://greenkeeper.io/

* docs(readme): add Greenkeeper badge

https://greenkeeper.io/

* Update to latest Semistandard
daffl pushed a commit that referenced this pull request Aug 21, 2018
@greenkeeper @daffl
Update dependencies to enable Greenkeeper 🌴 (#49)
4f00056 
* chore(package): update dependencies

https://greenkeeper.io/

* docs(readme): add Greenkeeper badge

https://greenkeeper.io/

* Update to latest Semistandard
daffl added a commit that referenced this pull request Aug 21, 2018
@daffl
Fix the event name and add some channel debug statements (#49)
f0c3de9
daffl pushed a commit that referenced this pull request Aug 21, 2018
@greenkeeperio-bot @daffl
chore(package): update feathers-commons to version 0.8.0 (#49)
a1d1a2c
daffl pushed a commit that referenced this pull request Aug 21, 2018
@greenkeeper @daffl
chore(package): update semistandard to version 11.0.0 (#49)
9816b50 
https://greenkeeper.io/
daffl added a commit that referenced this pull request Aug 22, 2018
@daffl
Fix the event name and add some channel debug statements (#49)
8a31f52
daffl pushed a commit that referenced this pull request Aug 22, 2018
@greenkeeperio-bot @daffl
chore(package): update feathers-commons to version 0.8.0 (#49)
9ed14ff
daffl pushed a commit that referenced this pull request Aug 22, 2018
@greenkeeper @daffl
chore(package): update semistandard to version 11.0.0 (#49)
509666d 
https://greenkeeper.io/
daffl pushed a commit that referenced this pull request Aug 23, 2018
@greenkeeper @daffl
chore(package): update mocha to version 4.0.0 (#49)
9236d92
daffl pushed a commit that referenced this pull request Aug 25, 2018
@ekryski @daffl
Merge pull request #49 from feathersjs/oauth
a49966b 
Oauth. Closes #2. Closes #229.
daffl added a commit that referenced this pull request Aug 25, 2018
@daffl
Update plugin generator to correspond with latest release (#49)
30a385a 
* Update plugin generator to correspond with latest release

* Add mocha to Semistandard env
daffl pushed a commit that referenced this pull request Aug 28, 2018
@greenkeeper @daffl
chore(package): update semistandard to version 12.0.0 (#49)
edc9dc7
daffl pushed a commit that referenced this pull request Aug 28, 2018
@greenkeeper @daffl
chore(package): update feathers-memory to version 2.0.0 (#49)
6c5e354
daffl added a commit that referenced this pull request Aug 29, 2018
@daffl
Update to new plugin infrastructure (#49)
6c600b9
daffl pushed a commit that referenced this pull request Aug 29, 2018
@greenkeeper @daffl
chore(package): update socket.io-client to version 2.0.0 (#49)
f7b9924
daffl pushed a commit that referenced this pull request Aug 29, 2018
@ekryski @daffl
Merge pull request #49 from feathersjs/decoupling
a920988 
Decoupling
daffl pushed a commit that referenced this pull request Aug 29, 2018
@greenkeeper @daffl
chore(package): update semistandard to version 12.0.0 (#49)
1b03e21
daffl pushed a commit that referenced this pull request Aug 29, 2018
@greenkeeper @daffl
chore(package): update feathers-memory to version 2.0.0 (#49)
19f42e6
daffl added a commit that referenced this pull request Aug 29, 2018
@daffl
Update to new plugin infrastructure (#49)
a7e6d0b
daffl pushed a commit that referenced this pull request Aug 29, 2018
@greenkeeper @daffl
chore(package): update socket.io-client to version 2.0.0 (#49)
a8fa220
daffl pushed a commit that referenced this pull request Aug 29, 2018
@ekryski @daffl
Merge pull request #49 from feathersjs/decoupling
7121bbe 
Decoupling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.4.0

Development

Successfully merging this pull request may close these issues.

1 participant

@daffl

Comments

Close sidebar
Morty Proxy This is a proxified and sanitized view of the page, visit original site.