Added patch support#47
Conversation
|
the pull request I stated for legs to make use of this PATCH request https://github.com/feathersjs/legs/pull/7 |
|
Yes! This makes total sense. I actually kept running into this myself. Although |
|
/cc @Glavin001 @ekryski |
|
👍 Code looks good. Would you be able to add a test for this, @mlaug, to test/provides/rest.test.js? Then I am all for merging this. Thanks! |
|
sure, as for the other pull request will create a test right after the weekend |
|
We should probably test this with SocketIO and Primus as well. The best way is probably adding the patch to https://github.com/feathersjs/feathers/blob/master/test/providers/service-fixture.js. We also shouldn't forget to document it and add it to the examples. |
|
Looks good. Thanks @mlaug. |
|
I have added testcases for the patch support, hope that suits it |
|
I've been a bit out of the loop lately but this looks good to me! @daffl or @Glavin001 I'll let you guys pull the trigger. |
|
Nice! Thanks again! I'll add some docs in the readme as well. |
|
👍 Thank you, @mlaug! |
* chore(package): update dependencies https://greenkeeper.io/ * docs(readme): add Greenkeeper badge https://greenkeeper.io/
* chore(package): update dependencies https://greenkeeper.io/ * docs(readme): add Greenkeeper badge https://greenkeeper.io/
No description provided.