fix(website): update @feathersdev/websites to 0.0.4** #3652
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 0.0.4 fixes the DocsSearch component to not render a duplicate modal, which was causing search to fail on docs pages due to incorrect collection auto-detection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes search not working on documentation pages.
The
DocsSearchcomponent from@feathersdev/websiteswas rendering its ownDocsSearchModalwithout collections configured, causing it to fall back to auto-detection which used wrong collection names (feathersDocs,pinionDocs, etc.) that don't exist on feathersjs.com.Version 0.0.4 fixes the component to only render a search button that triggers the global modal configured in
app.vuewith the correct collections.