fix(client): Buffer SSE stream chunks before parsing#3643
Merged
daffl merged 3 commits intov6feathersjs/feathers:v6from Jan 29, 2026
fix/sse-stream-bufferingfeathersjs/feathers:fix/sse-stream-bufferingCopy head branch name to clipboard
Merged
fix(client): Buffer SSE stream chunks before parsing#3643daffl merged 3 commits intov6feathersjs/feathers:v6from fix/sse-stream-bufferingfeathersjs/feathers:fix/sse-stream-bufferingCopy head branch name to clipboard
daffl merged 3 commits intov6feathersjs/feathers:v6from
fix/sse-stream-bufferingfeathersjs/feathers:fix/sse-stream-bufferingCopy head branch name to clipboard
Conversation
The handleEventStream method was parsing each chunk independently,
but TCP chunks don't align with SSE event boundaries. This caused
JSON parse errors when events were split across chunks.
For example:
- Chunk 1: data: {"response":"Hel
- Chunk 2: lo"}\n\ndata: {"response":" world"}\n\n
The fix buffers incoming data and only parses complete events
(those ending with the SSE delimiter \n\n).
Tests verify handleEventStream correctly handles: - Events split across TCP chunks - Multiple events in a single chunk - Events split at the \n\n delimiter boundary - Multi-byte UTF-8 characters split across chunks
Documents how to consume streaming responses from services that return async generators. Includes examples for AI/LLM streaming, progress updates, and notes about automatic SSE buffering.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
feathers-v6 | ccde4ca | Commit Preview URL Branch Preview URL |
Jan 29 2026, 04:02 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug in
FetchClient.handleEventStreamwhere SSE events split across TCP chunks would fail to parse.Problem
TCP chunks don't align with SSE event boundaries. When streaming responses arrive, a single
reader.read()call might return partial JSON:data: {"response":"Hello"}\n\ndata: {"response":" world"}\n\nThe previous implementation tried to parse each chunk independently, causing
JSON.parseto fail on incomplete data.Solution
Buffer incoming data and only parse complete SSE events (those terminated by
\n\n):Changes
FetchClient.handleEventStreamTesting
All existing tests pass plus 4 new tests:
handles SSE events split across chunkshandles multiple events in a single chunkhandles event split at delimiter boundary