fix(adapter-commons): clean up in sort.ts and select function#2492
Merged
daffl merged 1 commit intofeathersjs:dovefeathersjs/feathers:dovefrom Nov 26, 2021
vonagam:fix-adapter-commons-thingsvonagam/feathers:fix-adapter-commons-thingsCopy head branch name to clipboard
Merged
fix(adapter-commons): clean up in sort.ts and select function#2492daffl merged 1 commit intofeathersjs:dovefeathersjs/feathers:dovefrom vonagam:fix-adapter-commons-thingsvonagam/feathers:fix-adapter-commons-thingsCopy head branch name to clipboard
daffl merged 1 commit intofeathersjs:dovefeathersjs/feathers:dovefrom
vonagam:fix-adapter-commons-thingsvonagam/feathers:fix-adapter-commons-thingsCopy head branch name to clipboard
Conversation
Member
|
Great call. I copied the sorting from NeDB a while ago (this is also why it doesn't have that many tests) and this is definitely nicee. Using the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After last merged PR looked into
sort.tsand saw some things that can be cleaned up. Did so.Also in
selectfunction there waspush()intoparams.query.$selectif they were present andotherFieldsprovided. Should be concated into new array instead.