Return type narrowing for service multi CRUD.#1717
Closed
deskoh wants to merge 1 commit intofeathersjs:masterfeathersjs/feathers:masterfrom
deskoh:prCopy head branch name to clipboard
Closed
Return type narrowing for service multi CRUD.#1717deskoh wants to merge 1 commit intofeathersjs:masterfeathersjs/feathers:masterfrom deskoh:prCopy head branch name to clipboard
deskoh wants to merge 1 commit intofeathersjs:masterfeathersjs/feathers:masterfrom
deskoh:prCopy head branch name to clipboard
Conversation
|
@deskoh I found this PR after fighting with this problem myself for a bit. What did you end up doing to resolve this issue for yourself? |
Contributor
Author
|
Take a look at this: https://github.com/feathersjs-ecosystem/databases/pull/4 Seems like the overloads were removed. Any comments @vonagam? |
Member
|
Good point, they should be added back in that file now. No idea yet if it will all play together nicely, there's a lot of changes in progress at https://github.com/feathersjs/feathers/tree/dove-typescript-refactor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR narrow the return type of service
multicreate,patchandremovemethods.Consider the following database service: