fix: Add info to express error handler logger type#1557
Merged
daffl merged 2 commits intofeathersjs:masterfeathersjs/feathers:masterfrom Sep 16, 2019
vonagam:fix-express-error-handler-typevonagam/feathers:fix-express-error-handler-typeCopy head branch name to clipboard
Merged
fix: Add info to express error handler logger type#1557daffl merged 2 commits intofeathersjs:masterfeathersjs/feathers:masterfrom vonagam:fix-express-error-handler-typevonagam/feathers:fix-express-error-handler-typeCopy head branch name to clipboard
daffl merged 2 commits intofeathersjs:masterfeathersjs/feathers:masterfrom
vonagam:fix-express-error-handler-typevonagam/feathers:fix-express-error-handler-typeCopy head branch name to clipboard
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If provided a logger should have
infoproperty, which is used here.Instead of
void | null, justvoidfor return type of logging functions.msgis not astring, butanysince it is used to log errors (as shown in link above) and they might not be a string.errorproperty is required now, if you don't want to log stuff, just do not provideloggersince it is optional already.