fix: Set authenticated: true after successful authentication#1367
Merged
daffl merged 1 commit intofeathersjs:masterfeathersjs/feathers:masterfrom May 25, 2019
Merged
fix: Set authenticated: true after successful authentication#1367daffl merged 1 commit intofeathersjs:masterfeathersjs/feathers:masterfrom
daffl merged 1 commit intofeathersjs:masterfeathersjs/feathers:masterfrom
Conversation
Member
|
Good call. I removed it because it seemed redundant but with #1317 bringing back the param it makes sense to set it. |
Contributor
Author
|
One alternative thought.. When i first wrote some feathers tests, it seemed a little superfluous that i had to pass both { user, authenticated }. And so i think it was interesting that you were trying to remove the need for that param, by hiding it more behind an internal symbol. But what if presence of user object would be enough to treat requests as authenticated. So instead of using/checking authenticated we just have { user }. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1360