Fix authentication client logout function to guard against null #1319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
889fcd7 to
67d9cbc
Compare
Member
|
I think this fix makes sense I'm just wondering why this was happening because |
Contributor
Author
|
Ah, I see, thats right. Maybe it was related to some other auth issues i was experiencing. I will double check. |
Contributor
Author
|
Yeah, when I call logout, the authentication is indeed defined. The reason it was undefined previously is possibly related to the other issues where I would succesfully authenticate, but then jwt strategy would not work for me logging me out. Hm.. or maybe I was just calling logout while being logged out expecting that not to throw. In any case, can't hurt to guard, I guess. Good to know it's all working fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1318