fix(client): Buffer SSE stream chunks before parsing #3643
Merged
+212
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug in
FetchClient.handleEventStreamwhere SSE events split across TCP chunks would fail to parse.Problem
TCP chunks don't align with SSE event boundaries. When streaming responses arrive, a single
reader.read()call might return partial JSON:data: {"response":"Hello"}\n\ndata: {"response":" world"}\n\nThe previous implementation tried to parse each chunk independently, causing
JSON.parseto fail on incomplete data.Solution
Buffer incoming data and only parse complete SSE events (those terminated by
\n\n):Changes
FetchClient.handleEventStreamTesting
All existing tests pass plus 4 new tests:
handles SSE events split across chunkshandles multiple events in a single chunkhandles event split at delimiter boundary