fix: @feathersjs/memory update with query#3617
Merged
daffl merged 4 commits intodovefeathersjs/feathers:dovefrom Sep 30, 2025
fix/dove-memory-update-selectfeathersjs/feathers:fix/dove-memory-update-selectCopy head branch name to clipboard
Merged
fix: @feathersjs/memory update with query#3617daffl merged 4 commits intodovefeathersjs/feathers:dovefrom fix/dove-memory-update-selectfeathersjs/feathers:fix/dove-memory-update-selectCopy head branch name to clipboard
daffl merged 4 commits intodovefeathersjs/feathers:dovefrom
fix/dove-memory-update-selectfeathersjs/feathers:fix/dove-memory-update-selectCopy head branch name to clipboard
Conversation
daffl
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR:
@feathersjs/memory:.update()with a query (resulting inNotFound) updates data instead of preventing the change.adapter-testshas a test case for.update + id + querybut it produces a false positive (at least for@feathersjs/memory). It checks forNotFoundbut does not safely detect if definitely nothing was changed.In case of an
.update()with a query, the current implementation of@feathersjs/memorychanges the data first, stores the changed data and then throws afterwards.So I included an explicit check in
@feathersjs/adapter-testsand fixed it by passingparamsto the first_.get()inupdate.While being at it, I also replaced
@feathersjs/commonswith native methods (third commit).