fix: Small improvements#1605
Merged
daffl merged 1 commit intofeathersjs:masterfeathersjs/feathers:masterfrom Oct 7, 2019
Merged
fix: Small improvements#1605daffl merged 1 commit intofeathersjs:masterfeathersjs/feathers:masterfrom
daffl merged 1 commit intofeathersjs:masterfeathersjs/feathers:masterfrom
Conversation
Member
|
That makes sense, thanks! I thought this was being tested but I guess the test only covered that the authentication information had been removed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small types and consistency style fixes. But also one real fix:
handleConnectionmethod ofAuthenticationBaseandJWTStrategywas never called in response todisconnectevent, so when a jwt expiration timer emitteddisconnectconnection.authenticationwas not removed and the timer was not cleared. Added listener fordisconnectevent to fix this. Also addedexpirationTimers.deleteafter a timer is cleared andlt.clearTimeoutbefore a timer is set (to ensure that only one timer per connection exist at a time, otherwise multiple calls toreAuthenticatewith force can create more than one timer).