fix: @feathersjs/express: allow middleware arrays#1421
Merged
daffl merged 2 commits intofeathersjs:masterfeathersjs/feathers:masterfrom Jun 30, 2019
vonagam:feat-middleware-arraysvonagam/feathers:feat-middleware-arraysCopy head branch name to clipboard
Merged
fix: @feathersjs/express: allow middleware arrays#1421daffl merged 2 commits intofeathersjs:masterfeathersjs/feathers:masterfrom vonagam:feat-middleware-arraysvonagam/feathers:feat-middleware-arraysCopy head branch name to clipboard
daffl merged 2 commits intofeathersjs:masterfeathersjs/feathers:masterfrom
vonagam:feat-middleware-arraysvonagam/feathers:feat-middleware-arraysCopy head branch name to clipboard
Conversation
Member
|
🎉 Will also go out with the next pre-release next week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using as many middleware arrays or functions as you want is valid for express, since it uses
array-flattenon passed arguments (1, 2).Now does not throw on valid usage for express and allows to use arrays of middleware before and after feathers service.