From 0b6cfe8804b675fa3c73251548a1dc565f2dd73a Mon Sep 17 00:00:00 2001
From: Matthias Max <matthias.max@bitflower.net>
Date: Sat, 11 May 2019 01:57:50 +0200
Subject: [PATCH 1/2] finally should be optional

---
 packages/feathers/index.d.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/feathers/index.d.ts b/packages/feathers/index.d.ts
index 9273162581..6f1e7a860b 100644
--- a/packages/feathers/index.d.ts
+++ b/packages/feathers/index.d.ts
@@ -135,7 +135,7 @@ export interface HooksObject {
     before: Partial<HookMap> | Hook | Hook[];
     after: Partial<HookMap> | Hook | Hook[];
     error: Partial<HookMap> | Hook | Hook[];
-    finally: Partial<HookMap> | Hook | Hook[];
+    finally?: Partial<HookMap> | Hook | Hook[];
 }
 
 // todo: figure out what to do: These methods don't actually need to be implemented, so they can be undefined at runtime. Yet making them optional gets cumbersome in strict mode.

From 7990cc76a66799fbcfba389aa5028b6d61ab81e3 Mon Sep 17 00:00:00 2001
From: David Luecke <daff@neyeon.com>
Date: Mon, 13 May 2019 18:56:23 -0700
Subject: [PATCH 2/2] Remove outdated comment

---
 packages/feathers/index.d.ts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/packages/feathers/index.d.ts b/packages/feathers/index.d.ts
index 6f1e7a860b..fcc256dd7f 100644
--- a/packages/feathers/index.d.ts
+++ b/packages/feathers/index.d.ts
@@ -138,7 +138,6 @@ export interface HooksObject {
     finally?: Partial<HookMap> | Hook | Hook[];
 }
 
-// todo: figure out what to do: These methods don't actually need to be implemented, so they can be undefined at runtime. Yet making them optional gets cumbersome in strict mode.
 export interface ServiceMethods<T> {
     [key: string]: any;