Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Write feature API on Serving service #1461

Copy link
Copy link
@RoyTal28

Description

@RoyTal28
Issue body actions

Hey guys :),
According to the initial discussion that my colleague created.
I want to elaborate more about the write features API and share the proto file for initial feedback.

We think that the API should basically push feature rows for specific feature tables and projects to the online store in a similar way the ingestion logic works (RedisSinkRelation.scala).

The suggested change to the serving proto file is as follows:

image

Details explanation:
The PushOnlineFeatureRequest contains a definition of the feature table and the project.
And a key-value map containing the values of each row.

**We assume that the feature table and the project (if empty we use default) already exist and validate it.

The PushOnlineFeatureResponse contains a list of RowStatus that represent the pushing status of each row.

I would love to have your feedback so we can move forward and prepare a pull request soon.

Thanks!

aaraujo, woop and rmankevichwoop

Metadata

Metadata

Assignees

No one assigned

    Labels

    wontfixThis will not be worked onThis will not be worked on

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.