Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fixes array issue that was causing incompatibility in the subsample a… #803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

apasarkar
Copy link
Collaborator

@apasarkar apasarkar commented Apr 18, 2025

Small change, allows lazy arrays to pass as expected through the subsample (and the vmin/vmax quick computation) functions. Fixes #804

@kushalkolar
Copy link
Member

Ah this is because whatever np.nanmin calls isn't implemented for your lazy arrays. If you have a way to pre-compute the min and max for your lazy arrays that would be fastest.

@kushalkolar kushalkolar merged commit 29b098d into fastplotlib:main Apr 18, 2025
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected subsample_array behavior
2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.