Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix comment, fix doc example readme file #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 17, 2025
Merged

Conversation

kushalkolar
Copy link
Member

old comment lingering from when graphics were weakrefs (before we dug into the ways ipython docs gc)

@kushalkolar kushalkolar requested a review from clewis7 as a code owner March 17, 2025 02:16
@kushalkolar
Copy link
Member Author

Failure makes no sense, I can't produce locally O_O

    def test_gray():
        fig = fpl.Figure()
        ig = fig[0, 0].add_image(GRAY_IMAGE)
        assert isinstance(ig, fpl.ImageGraphic)
    
        ig.add_event_handler(
            event_handler,
            "data",
            "cmap",
            "vmin",
            "vmax",
            "interpolation",
            "cmap_interpolation",
        )
    
        # make sure entire data is the same
        npt.assert_almost_equal(ig.data.value, GRAY_IMAGE)
    
        # since this entire image is under the wgpu max texture limit,
        # the entire image should be in the single Texture buffer
        npt.assert_almost_equal(ig.data.buffer[0, 0].data, GRAY_IMAGE)
    
>       ig.cmap = "viridis"

tests/test_image_graphic.py:89: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
fastplotlib/graphics/image.py:205: in cmap
    self._cmap.set_value(self, name)
fastplotlib/graphics/_features/_base.py:346: in set_value_wrapper
    raise exc  # set_value has raised. The line above and the lines 2+ steps below are probably more relevant!
fastplotlib/graphics/_features/_base.py:343: in set_value_wrapper
    set_value(self, graphic_or_key, value)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <fastplotlib.graphics._features._image.ImageCmap object at 0x114c90410>
graphic = ImageGraphic, value = 'viridis'

    @block_reentrance
    def set_value(self, graphic, value: str):
        new_colors = make_colors(256, value)
>       graphic._material.map.texture.data[:] = new_colors
E       AttributeError: 'TextureMap' object has no attribute 'data'

@kushalkolar
Copy link
Member Author

Ah the change is because cmap now returns a TextureMap instead of a Texture

Copy link

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/fix-comment-fix-doc-readme

@kushalkolar
Copy link
Member Author

@clewis7 gtg!

@clewis7 clewis7 merged commit 61d7962 into main Mar 17, 2025
28 of 52 checks passed
@clewis7 clewis7 deleted the fix-comment-fix-doc-readme branch March 17, 2025 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.