add job that uses release version of pygfx #706
Conversation
|
📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/test-pygfx-pypi |
|
|
|
ok this was getting too complicated, let's just add pygfx-release/main to the matrix and during PRs we just manually look at the job statuses and determine if we want to merge or not based on any pygfx-release failures. This is only really necessary until pygfx stabilizes so we don't want to spend too much effort making a complicated thing that's only for this temporary phase of developement @clewis7 what do you think? |
|
@clewis7 ready for review! |
But will having the CI badge as failing look bad? I feel like that's something I look at when I look at a repo 😳 |
True, we can remove the CI badge for now? |
But does that also look bad? I can't decide what the best optics are lol |
pygfx seems like it'll stabilize over the coming months, it's fine for now I think. |
|
was too complicated to figure out alternatives and not worth it for something temporary |
closes #702
see this comment #706 (comment)
Instead of adding it to the matrix I just made a new identical job so we can use the branch protection rules instead of the more complicated check and message system linked in that issueWill see if this works, I've set "Test Linux" (which usespygfx@main) as a required status check that must pass for a PR to be merged and I wonder if that will cover the entire matrix for that job. "Test Linux pygfx release" is however not required to pass.