Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

updates related to upstream changes #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Jan 6, 2025
Merged

updates related to upstream changes #687

merged 15 commits into from
Jan 6, 2025

Conversation

kushalkolar
Copy link
Member

@kushalkolar kushalkolar commented Dec 25, 2024 •
edited
Loading

This PR catches up with a number of upstream changes:

kushalkolar and others added 2 commits December 24, 2024 23:35
@kushalkolar
use imageio[ffmpeg] instead of pyav (#686)
5c12b36
@jcafhe @kushalkolar
fix typo in the requested limit name of the wgpu device (#679)
0937309 
* fix typo in the requested limit name of the wgpu device.

* fix test config.

* fix examples/test and docs

* fix max-texture-dimension-2d limit name and replace underscore by hyphen for the other limits.

* fix missing dependency (libxrandr) to compile GLFW during building wheel for imgui-bundle.

* update CI timeout

* update timeout in non-nb test job

---------

Co-authored-by: Kushal Kolar <kushalkolar@gmail.com>
@kushalkolar kushalkolar requested a review from clewis7 as a code owner December 25, 2024 04:38
@kushalkolar kushalkolar changed the title Extinguish fires updates related to upstream changes Dec 25, 2024
@kushalkolar
Copy link
Member Author

doc failure is because the pygfx gallery scraper now checks for BaseRenderCanvas instead of WgpuCanvas. Anyways wgpu.gui is going to be dropped soon so we should update things to use rendercanvas instead.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 26, 2024 •
edited
Loading

📚 Docs preview built and uploaded! https://www.fastplotlib.org/ver/extinguish-fires

@kushalkolar
Copy link
Member Author

I think the current failures in the nb tests might be due to changes in the latest jupyterlab

@kushalkolar
Copy link
Member Author

I figured it out, since the starting size of the jupyter canvas is (0, 0) we get blank screenshots until the second screenshot is requested. But then that second screenshot is not sized correctly so I think it's processing events or something. If pygfx/rendercanvas#50 is merged then this will be fixed.

@kushalkolar kushalkolar mentioned this pull request Dec 26, 2024
Closed
7 tasks
@kushalkolar
Copy link
Member Author

waiting for next release of rendercanvas with pygfx/rendercanvas#50 . Tests passing locally with latest rendercanvas on main.

@kushalkolar
Copy link
Member Author

@clewis7 ready for review!

clewis7
clewis7 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@clewis7 clewis7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't tell just from looking at the diffs... What is the reason for the change from fpl.run() to fpl.loop.run()? Because we are using rendercanvas now?

.github/workflows/ci.yml Show resolved Hide resolved
@clewis7 clewis7 merged commit 07053e7 into main Jan 6, 2025
9 checks passed
@clewis7 clewis7 deleted the extinguish-fires branch January 6, 2025 14:06
FlynnOConnell pushed a commit to FlynnOConnell/fastplotlib that referenced this pull request Jan 7, 2025
@kushalkolar @jcafhe @FlynnOConnell
updates related to upstream changes (fastplotlib#687)
c537ae6 
* use imageio[ffmpeg] instead of pyav (fastplotlib#686)

* fix typo in the requested limit name of the wgpu device (fastplotlib#679)

* fix typo in the requested limit name of the wgpu device.

* fix test config.

* fix examples/test and docs

* fix max-texture-dimension-2d limit name and replace underscore by hyphen for the other limits.

* fix missing dependency (libxrandr) to compile GLFW during building wheel for imgui-bundle.

* update CI timeout

* update timeout in non-nb test job

---------

Co-authored-by: Kushal Kolar <kushalkolar@gmail.com>

* update to use pygfx.TextureMap

* forgot to set imageio[ffmpeg] for all extras

* migrate to RenderCanvas, remove event_filter stuff for imgui since that was fixed in pygfx

* remove very old irrelevant example

* fix docstring

* update examples to use fpl.loop.run()

* update API docs

* black

* import ImageWidget only if imgui is installed

* enumerate_adapters() -> enumerate_adapters_sync()

* remove annoying warnings from cmap

* remove more cmap warnings

* black

---------

Co-authored-by: Jérémie Fache <jeremie.fache@netcourrier.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clewis7 clewis7 clewis7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Optional package imgui-bundle is now mandatory
3 participants
@kushalkolar @clewis7 @jcafhe
Morty Proxy This is a proxified and sanitized view of the page, visit original site.