further changes and ideas

fastplotlib · clewis7 · Dec 12, 2022 · Dec 12, 2022 · Dec 14, 2022 · Dec 15, 2022
commit 10aeca8934ee8b7c67066d82050c68003ed15731
diff --git a/fastplotlib/graphics/_base.py b/fastplotlib/graphics/_base.py
@@ -5,6 +5,7 @@

 from fastplotlib.utils import get_colors, map_labels_to_colors

+from abc import ABC, abstractmethod

 class Graphic:
    def __init__(
@@ -68,28 +69,35 @@ def __repr__(self):
        else:
            return f"fastplotlib.{self.__class__.__name__} @ {hex(id(self))}"

-class Interaction:
+class Interaction(ABC):
    # make them abstract properties
    @property
+    @abstractmethod
    def indices(self) -> Any:
        pass

    @indices.setter
+    @abstractmethod
    def indices(self, indices: Any):
        pass

    @property
+    @abstractmethod
    def features(self) -> List[str]:
        pass

+    @abstractmethod
    def _set_feature(self, name: str, new_data: Any, indices: Any):
        pass

+    @abstractmethod
    def link(self, event: str, feature: Any, feature_data: Any, target: Graphic, target_feature: Any, target_data: Any, indices_mapper: Any):
        # event occurs, causes change in feature of current graphic to data indices from pick_info,
        # also causes change in target graphic to target feature at target data with corresponding or mapped
        # indices based on the indice_mapper function

+        # events can be feature changes, when feature changes want to trigger an event
+
        # indice mapper takes in source features and maps to target features
        pass


diff --git a/fastplotlib/graphics/heatmap.py b/fastplotlib/graphics/heatmap.py
@@ -1,10 +1,15 @@
 import numpy as np
 import pygfx
 from typing import *
+
+from fastplotlib.graphics._base import Graphic
+
 from .image import ImageGraphic

 from ..utils import quick_min_max, get_cmap_texture

+from ._base import Interaction
+

 default_selection_options = {
    "mode": "single",
@@ -40,7 +45,22 @@ def __init__(
            self.callbacks = callbacks


-class HeatmapGraphic(ImageGraphic):
+class HeatmapGraphic(ImageGraphic, Interaction):
+    @property
+    def indices(self) -> Any:
+        pass
+
+    @property
+    def features(self) -> List[str]:
+        pass
+
+    def _set_feature(self, name: str, new_data: Any, indices: Any):
+        pass
+
+    def link(self, event: str, feature: Any, feature_data: Any, target: Graphic, target_feature: Any, target_data: Any,
+             indices_mapper: Any):
+        pass
+
    def __init__(
            self,
            data: np.ndarray,