Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

gridplot controllers kwarg is back, other improvements to gp #477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 7, 2024
Merged

gridplot controllers kwarg is back, other improvements to gp #477

merged 7 commits into from
Apr 7, 2024

Conversation

kushalkolar
Copy link
Member

@kushalkolar kushalkolar commented Apr 7, 2024 •
edited
Loading

closes #425

  • controllers kwarg to Gridplot to manually pass pygfx.Controller instance(s), all other controller kwargs are ignored if this is passed
  • add @cameras and @controllers properties to Gridplot
  • tests the various cameras and controllers kwargs, and changing cameras and controllers after gridplot creation

@kushalkolar kushalkolar marked this pull request as ready for review April 7, 2024 09:57
@kushalkolar kushalkolar requested a review from clewis7 as a code owner April 7, 2024 09:57
@kushalkolar kushalkolar merged commit 418a73b into main Apr 7, 2024
@kushalkolar kushalkolar deleted the gp-controllers-kwarg branch April 7, 2024 10:45
clewis7
clewis7 reviewed Apr 9, 2024
View reviewed changes
fastplotlib/layouts/_gridplot.py Show resolved Hide resolved
fastplotlib/layouts/_gridplot.py Show resolved Hide resolved
fastplotlib/layouts/_gridplot.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clewis7 clewis7 clewis7 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Directly pass Controller instances to GridPlot
2 participants
@kushalkolar @clewis7
Morty Proxy This is a proxified and sanitized view of the page, visit original site.