-
Notifications
You must be signed in to change notification settings - Fork 53
legends, part 1 #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
legends, part 1 #406
Conversation
I should determine a way to make a sorting method for LegendItems in space (based on the size of each) and then organize into an optimal column, row or grid of items. Get the bbox for all LegendItems and set the Legend mesh to the bbox. |
If legend is placed in the main plot area scale the text size and spacing based on current scene bbox. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a plan to have something like plot.add_legend()
, that would take a plot_area
and auto generate a legend based on existing graphics in the plot?
Notes:
- Interesting functionality, if I don't specify a dock to put the legend in, it places it in the middle of the plot. Should we have a default dock to use ("top" or "right") if someone just passes the plot?
- Also, if I don't change the size of the dock before adding the legend, it doesn't appear? Should we automatically change the size of the dock area that the legend is being added to?
- Legend location: it appears like the legend is not centered in the middle of the plot.
I see here you provided images exemplifying use, I think we should add a @kushalkolar thoughts? |
I see you can pass a |
We can think about this later once we have all the legend functionality we want.
Nope, it can make sense to put the legend in the main plot area too, the user can move them out of the way of existing graphics if required.
Done
We can fix this later XD
We can do this after implementing all legend functionality that we want, basically when we fully resolve #403
Yup! |
Now after the recent References refactor I realize this is probably the best way to do it, keep the API uniform. Can properly look into it after or during axes. |
starts #403
major WIP