Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

make hlut widget optional #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2023
Merged

make hlut widget optional #351

merged 2 commits into from
Nov 3, 2023

Conversation

clewis7
Copy link
Member

@clewis7 clewis7 commented Oct 31, 2023

No description provided.

@clewis7
Copy link
Member Author

clewis7 commented Oct 31, 2023

would be nice to add an hlut button to the toolbar so it can be generated after imagewidget instantiation if a user wanted one for a specific subplot!

fastplotlib/widgets/image.py Outdated Show resolved Hide resolved
@kushalkolar
Copy link
Member

kushalkolar commented Oct 31, 2023

would be nice to add an hlut button to the toolbar so it can be generated after imagewidget instantiation if a user wanted one for a specific subplot!

I think this is feature creep, they can create and add it programmatically if they need that level of customization?

@kushalkolar
Copy link
Member

Also add kwarg to specify subsample dims for HistogramLut widget?

fastplotlib/widgets/image.py Outdated Show resolved Hide resolved
fastplotlib/widgets/image.py Outdated Show resolved Hide resolved
@clewis7
Copy link
Member Author

clewis7 commented Nov 1, 2023

Also add kwarg to specify subsample dims for HistogramLut widget?

@kushalkolar anything more than number of bins? or you want a dict that allows user to pass nbins and flank?

@kushalkolar
Copy link
Member

Also add kwarg to specify subsample dims for HistogramLut widget?

@kushalkolar anything more than number of bins? or you want a dict that allows user to pass nbins and flank?

Just a tuple of its to specify the max size?

@kushalkolar kushalkolar marked this pull request as ready for review November 3, 2023 04:06
@kushalkolar
Copy link
Member

going to merge this, see #359 for the subsample

@kushalkolar kushalkolar merged commit c1cf47f into main Nov 3, 2023
@kushalkolar kushalkolar deleted the iw_hlut branch November 4, 2023 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.