Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

vertex_colors -> color_mode='vertex' #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 2, 2023
Merged

vertex_colors -> color_mode='vertex' #312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01f6d95
vertex_colors -> color_mode='vertex'
kushalkolar Oct 2, 2023
b86832a
update ci to use pygfx@main instead of a specific commit
kushalkolar Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions 4 .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
python -m pip install --upgrade pip
# remove pygfx from requirements, we install a specific commit of pygfx since both fpl and pygfx are fast evolving
sed -i "/pygfx/d" ./setup.py
pip install git+https://github.com/pygfx/pygfx.git@cf1da6c32223ba3cf7256982ce9b89c81b593076
pip install git+https://github.com/pygfx/pygfx.git@main
pip install -e ".[notebook,docs,tests]"
- name: Build docs
run: |
Expand Down Expand Up @@ -78,7 +78,7 @@ jobs:
python -m pip install --upgrade pip
# remove pygfx from requirements, we install a specific commit of pygfx since both fpl and pygfx are fast evolving
sed -i "/pygfx/d" ./setup.py
pip install git+https://github.com/pygfx/pygfx.git@cf1da6c32223ba3cf7256982ce9b89c81b593076
pip install git+https://github.com/pygfx/pygfx.git@main
pip install -e ".["tests"]"
- name: Show wgpu backend
run:
Expand Down
2 changes: 1 addition & 1 deletion 2 .github/workflows/screenshots.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
python -m pip install --upgrade pip
# remove pygfx from requirements, we install a specific commit of pygfx since both fpl and pygfx are fast evolving
sed -i "/pygfx/d" ./setup.py
pip install git+https://github.com/pygfx/pygfx.git@b63f22a1aa61993c32cd96895316cb8248a81e4d
pip install git+https://github.com/pygfx/pygfx.git@main
pip install -e ".["tests"]"
- name: Show wgpu backend
run:
Expand Down
2 changes: 1 addition & 1 deletion 2 fastplotlib/graphics/line.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ def __init__(
world_object: pygfx.Line = pygfx.Line(
# self.data.feature_data because data is a Buffer
geometry=pygfx.Geometry(positions=self.data(), colors=self.colors()),
material=material(thickness=self.thickness(), vertex_colors=True),
material=material(thickness=self.thickness(), color_mode="vertex"),
)

self._set_world_object(world_object)
Expand Down
2 changes: 1 addition & 1 deletion 2 fastplotlib/graphics/scatter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ def __init__(

world_object = pygfx.Points(
pygfx.Geometry(positions=self.data(), sizes=self.sizes(), colors=self.colors()),
material=pygfx.PointsMaterial(vertex_colors=True, vertex_sizes=True),
material=pygfx.PointsMaterial(color_mode="vertex", vertex_sizes=True),
)

self._set_world_object(world_object)
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.