Skip to content

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

"DockedViewport" - Viewports adjacent to Subplot Viewport #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 11, 2022

Conversation

kushalkolar
Copy link
Member

start implementing #29

@kushalkolar
Copy link
Member Author

kushalkolar commented Nov 19, 2022

"docked subplots" now work on any side of a subplot, this will allow making a histogram LUT widget similar to pyqtgraph's

image

things to consider:

  1. make a "view area" class which is kinda like a Subplot, but they can only exist as children of a subplot and are shown within the original Subplot viewport area. Also this way Subplot itself can mostly just keep plotting relevant capabilities.
PlotArea:
    attrs:
        parent
        position
        renderer
        camera
        controller
    methods:
        get_rect()
        set_viewport_rect()
        render()
        add_graphic()
        center_graphic()
...
  1. Start a module for widgets like the HistogramLUTWidget which are more complex than just single Graphic items.

fastplotlib/subplot.py Outdated Show resolved Hide resolved
@kushalkolar kushalkolar mentioned this pull request Dec 2, 2022
9 tasks
@kushalkolar kushalkolar changed the title histogram widget and sub_viewports in Subplot "DockedViewport" - Viewports adjacent to Subplot Viewport Dec 9, 2022
@kushalkolar kushalkolar mentioned this pull request Dec 9, 2022
67 tasks
@kushalkolar kushalkolar merged commit daf6984 into master Dec 11, 2022
This was referenced Dec 15, 2022
@kushalkolar kushalkolar deleted the histwidget branch January 7, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.