catch up with pygfx refactor of of cameras, controllers, and Texture #163
Conversation
|
will need to update |
|
Can you wrap multiple Controllers and then pass the wrappers events to the separate Controllers? |
You mean one controller for multiple viewports (that's how it is currently), and then pass events separately to the cameras? |
|
You said:
I think we intend the same thing, but I'm suggesting a 1-1 relation between Controller and Camera. But having 1 Controller control 2 other Controller. I think you're suggesting to have 1 Controller control 2 or more Cameras Either way, it was more philosophical, I'm sure you'll find a way to adapt 😉 |
|
Ah, so it's now written that a controller can control a controller?
Anyways this is a very minor regression and we probably won't fix it until
we get a use case.
Thanks fit the comments!
…On Fri, Apr 14, 2023, 11:35 Ivo Flipse ***@***.***> wrote:
You said:
The only thing that is a regression is that it's not possible to use the
same controller on two cameras with different states,
I think we intend the same thing, but I'm suggesting a 1-1 relation
between Controller and Camera. But having 1 Controller control 2 other
Controller. I think you're suggesting to have 1 Controller control 2 or
more Cameras
Either way, it was more philosophical, I'm sure you'll find a way to adapt
😉
—
Reply to this email directly, view it on GitHub
<#163 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACHXXRBICMP3DAPE3TN7TQDXBFVC5ANCNFSM6AAAAAAW56SUTQ>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
|
Well I was suggesting that you wrap it with a Controller that controls Controllers 😉 But I think you're wise to wait until you actually have a need for it |
This implements latest changes from pygfx for the cameras, controllers, and Texture refactor:
This simplified a lot of things in fastplotlib:
PlotArea._refresh_cameras()is gonePlotAreacenter_graphic(),center_scene(),auto_scale(), simplifiedTexturedirectly instead ofTexture.get_view()inImageGraphicandHeatmapGraphicThe only thing that is a regression is that it's not possible to use the same controller on two cameras with different states, so the more complex Scatter and Line examples where the cameras are flipped on some subplots doesn't work anymore, using the controllers for these plots will make all the cameras have the same state as the first camera added to the controller. Minor feature regression but I don't think anyone was using cameras in this way anyways.
Other than the above regression all examples work, our big epic visualization with calcium & behavior data also works so this is good to go!