better buffer handling #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clewis7
reviewed
Mar 10, 2023
| # initialize a buffer with the same shape as the input data | ||
| # we do not directly use the input data array as the buffer | ||
| # because if the input array is a read-only type, such as | ||
| # numpy memmaps, we would not be able to change the image data |
There was a problem hiding this comment.
so, the point of having the option for using an isolated buffer is to be able to change data in the event that the type of the data is read only? will this occur when using improv?
clewis7
reviewed
Mar 10, 2023
|
|
||
| if (vmin is None) or (vmax is None): | ||
| vmin, vmax = quick_min_max(data) | ||
|
|
||
| texture_view = pygfx.Texture(self.data(), dim=2).get_view(filter=filter) | ||
| texture_view = pygfx.Texture(buffer_init, dim=2).get_view(filter=filter) |
There was a problem hiding this comment.
before, Texture and Geometry were all under the hood correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addresses #147
ImageGraphicandHeatmapGraphicallow setting the input array buffer directly as the texture data buffer ifisolated_buffer=False. The default isTrue, so by default the texture data buffer is a new array that is initialized using the shape and type of the input array, and then the isolated texture data buffer is set using the input data array values.allows this type of behavior:
