Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Commit c3fd72e

Browse filesBrowse files
kushalkolarkushalkolar
authored
vertex_colors -> color_mode='vertex' (#312)
* vertex_colors -> color_mode='vertex' * update ci to use pygfx@main instead of a specific commit
1 parent b770a8b commit c3fd72e
Copy full SHA for c3fd72e

File tree

4 files changed

+5
-5
lines changed
Filter options

4 files changed

+5
-5
lines changed

‎.github/workflows/ci.yml

Copy file name to clipboardExpand all lines: .github/workflows/ci.yml
+2-2Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ jobs:
3939
python -m pip install --upgrade pip
4040
# remove pygfx from requirements, we install a specific commit of pygfx since both fpl and pygfx are fast evolving
4141
sed -i "/pygfx/d" ./setup.py
42-
pip install git+https://github.com/pygfx/pygfx.git@cf1da6c32223ba3cf7256982ce9b89c81b593076
42+
pip install git+https://github.com/pygfx/pygfx.git@main
4343
pip install -e ".[notebook,docs,tests]"
4444
- name: Build docs
4545
run: |
@@ -78,7 +78,7 @@ jobs:
7878
python -m pip install --upgrade pip
7979
# remove pygfx from requirements, we install a specific commit of pygfx since both fpl and pygfx are fast evolving
8080
sed -i "/pygfx/d" ./setup.py
81-
pip install git+https://github.com/pygfx/pygfx.git@cf1da6c32223ba3cf7256982ce9b89c81b593076
81+
pip install git+https://github.com/pygfx/pygfx.git@main
8282
pip install -e ".["tests"]"
8383
- name: Show wgpu backend
8484
run:

‎.github/workflows/screenshots.yml

Copy file name to clipboardExpand all lines: .github/workflows/screenshots.yml
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333
python -m pip install --upgrade pip
3434
# remove pygfx from requirements, we install a specific commit of pygfx since both fpl and pygfx are fast evolving
3535
sed -i "/pygfx/d" ./setup.py
36-
pip install git+https://github.com/pygfx/pygfx.git@b63f22a1aa61993c32cd96895316cb8248a81e4d
36+
pip install git+https://github.com/pygfx/pygfx.git@main
3737
pip install -e ".["tests"]"
3838
- name: Show wgpu backend
3939
run:

‎fastplotlib/graphics/line.py

Copy file name to clipboardExpand all lines: fastplotlib/graphics/line.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ def __init__(
114114
world_object: pygfx.Line = pygfx.Line(
115115
# self.data.feature_data because data is a Buffer
116116
geometry=pygfx.Geometry(positions=self.data(), colors=self.colors()),
117-
material=material(thickness=self.thickness(), vertex_colors=True),
117+
material=material(thickness=self.thickness(), color_mode="vertex"),
118118
)
119119

120120
self._set_world_object(world_object)

‎fastplotlib/graphics/scatter.py

Copy file name to clipboardExpand all lines: fastplotlib/graphics/scatter.py
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ def __init__(
9191

9292
world_object = pygfx.Points(
9393
pygfx.Geometry(positions=self.data(), sizes=self.sizes(), colors=self.colors()),
94-
material=pygfx.PointsMaterial(vertex_colors=True, vertex_sizes=True),
94+
material=pygfx.PointsMaterial(color_mode="vertex", vertex_sizes=True),
9595
)
9696

9797
self._set_world_object(world_object)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.