fastplotlib
diff --git a/Collapse file
‎fastplotlib/graphics/line.py‎
Copy file name to clipboardExpand all lines: fastplotlib/graphics/line.py
+48-88Lines changed: 48 additions & 88 deletions b/Collapse file
‎fastplotlib/graphics/line.py‎
Copy file name to clipboardExpand all lines: fastplotlib/graphics/line.py
+48-88Lines changed: 48 additions & 88 deletions
@@ -114,11 +114,16 @@ def add_linear_selector(
 
         Parameters
         ----------
-        selection: float
-            initial position of the selector
+        Parameters
+        ----------
+        selection: float, optional
+            selected point on the linear selector, computed from data if not provided
+
+        axis: str, default "x"
+            axis that the selector resides on
 
-        padding: float
-            pad the length of the selector
+        padding: float, default 0.0
+            Extra padding to extend the linear selector along the orthogonal axis to make it easier to interact with.
 
         kwargs
             passed to :class:`.LinearSelector`
@@ -129,32 +134,10 @@ def add_linear_selector(
 
         """
 
-        data = self.data.value[~np.any(np.isnan(self.data.value), axis=1)]
-
-        if axis == "x":
-            # xvals
-            axis_vals = data[:, 0]
-
-            # yvals to get size and center
-            magn_vals = data[:, 1]
-        elif axis == "y":
-            axis_vals = data[:, 1]
-            magn_vals = data[:, 0]
+        bounds_init, limits, size, center = self._get_linear_selector_init_args(axis, padding)
 
         if selection is None:
-            selection = axis_vals[0]
-        limits = axis_vals[0], axis_vals[-1]
-
-        if not limits[0] <= selection <= limits[1]:
-            raise ValueError(
-                f"the passed selection: {selection} is beyond the limits: {limits}"
-            )
-
-        # width or height of selector
-        size = int(np.ptp(magn_vals) * 1.5 + padding)
-
-        # center of selector along the other axis
-        center = np.nanmean(magn_vals)
+            selection = bounds_init[0]
 
         selector = LinearSelector(
             selection=selection,
@@ -174,16 +157,26 @@ def add_linear_selector(
         return weakref.proxy(selector)
 
     def add_linear_region_selector(
-        self, padding: float = 0.0, axis: str = "x", **kwargs
+        self,
+        selection: tuple[float, float] = None,
+        padding: float = 0.0,
+        axis: str = "x",
+        **kwargs
     ) -> LinearRegionSelector:
         """
         Add a :class:`.LinearRegionSelector`. Selectors are just ``Graphic`` objects, so you can manage,
         remove, or delete them from a plot area just like any other ``Graphic``.
 
         Parameters
         ----------
-        padding: float, default 100.0
-            Extends the linear selector along the y-axis to make it easier to interact with.
+        selection: (float, float), optional
+            the starting bounds of the linear region selector, computed from data if not provided
+
+        axis: str, default "x"
+            axis that the selector resides on
+
+        padding: float, default 0.0
+            Extra padding to extend the linear region selector along the orthogonal axis to make it easier to interact with.
 
         kwargs
             passed to ``LinearRegionSelector``
@@ -195,34 +188,14 @@ def add_linear_region_selector(
 
         """
 
-        n_datapoints = self.data.value.shape[0]
-        value_25p = int(n_datapoints / 4)
+        bounds_init, limits, size, center = self._get_linear_selector_init_args(axis, padding)
 
-        # remove any nans
-        data = self.data.value[~np.any(np.isnan(self.data.value), axis=1)]
-
-        if axis == "x":
-            # xvals
-            axis_vals = data[:, 0]
-
-            # yvals to get size and center
-            magn_vals = data[:, 1]
-        elif axis == "y":
-            axis_vals = data[:, 1]
-            magn_vals = data[:, 0]
-
-        bounds_init = axis_vals[0], axis_vals[value_25p]
-        limits = axis_vals[0], axis_vals[-1]
-
-        # width or height of selector
-        size = int(np.ptp(magn_vals) * 1.5 + padding)
-
-        # center of selector along the other axis
-        center = np.nanmean(magn_vals)
+        if selection is None:
+            selection = bounds_init
 
         # create selector
         selector = LinearRegionSelector(
-            selection=bounds_init,
+            selection=selection,
             limits=limits,
             size=size,
             center=center,
@@ -241,44 +214,31 @@ def add_linear_region_selector(
         return weakref.proxy(selector)
 
     # TODO: this method is a bit of a mess, can refactor later
-    def _get_linear_selector_init_args(self, padding: float, **kwargs):
-        # computes initial bounds, limits, size and origin of linear selectors
-        data = self.data.value
+    def _get_linear_selector_init_args(self, axis: str, padding) -> tuple[tuple[float, float], tuple[float, float], float, float]:
+        # computes args to create selectors
+        n_datapoints = self.data.value.shape[0]
+        value_25p = int(n_datapoints / 4)
 
-        if "axis" in kwargs.keys():
-            axis = kwargs["axis"]
-        else:
-            axis = "x"
+        # remove any nans
+        data = self.data.value[~np.any(np.isnan(self.data.value), axis=1)]
 
         if axis == "x":
-            offset = self.offset[0]
-            # x limits
-            limits = (data[0, 0] + offset, data[-1, 0] + offset)
-
-            # height + padding
-            size = np.ptp(data[:, 1]) + padding
-
-            # initial position of the selector
-            position_y = (data[:, 1].min() + data[:, 1].max()) / 2
-
-            # need y offset too for this
-            origin = (limits[0] - offset, position_y + self.offset[1])
-
-        else:
-            offset = self.offset[1]
-            # y limits
-            limits = (data[0, 1] + offset, data[-1, 1] + offset)
+            # xvals
+            axis_vals = data[:, 0]
 
-            # width + padding
-            size = np.ptp(data[:, 0]) + padding
+            # yvals to get size and center
+            magn_vals = data[:, 1]
+        elif axis == "y":
+            axis_vals = data[:, 1]
+            magn_vals = data[:, 0]
 
-            # initial position of the selector
-            position_x = (data[:, 0].min() + data[:, 0].max()) / 2
+        bounds_init = axis_vals[0], axis_vals[value_25p]
+        limits = axis_vals[0], axis_vals[-1]
 
-            # need x offset too for this
-            origin = (position_x + self.offset[0], limits[0] - offset)
+        # width or height of selector
+        size = int(np.ptp(magn_vals) * 1.5 + padding)
 
-        # initial bounds are 20% of the limits range
-        bounds_init = (limits[0], int(np.ptp(limits) * 0.2) + offset)
+        # center of selector along the other axis
+        center = np.nanmean(magn_vals)
 
-        return bounds_init, limits, size, origin, axis
+        return bounds_init, limits, size, center