Fix / route with prefix in fastify@v3.10.1 #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
approved these changes
Jan 16, 2021
kibertoad
reviewed
Jan 16, 2021
| @@ -113,6 +110,6 @@ function close (fastify, done) { | ||
| } | ||
|
|
||
| module.exports = fp(fastifyWebsocket, { | ||
| fastify: '3.x', | ||
| fastify: '>= 3.10.1', |
There was a problem hiding this comment.
This does not qualify as a breaking change?
There was a problem hiding this comment.
Nope, in a real world application you should use lock files, so this wouldn't impact you until you want to upgrade.
Skn0tt
approved these changes
Jan 16, 2021
|
This was caused by: https://github.com/fastify/fastify/pull/2782/files. We had a few bugs in other plugins because it was called twice. (Note that the change in Fastify was not causing any tests failures here). cc @salmanm |
delvedor
approved these changes
Jan 16, 2021
|
@Skn0tt double |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #97
Checklist
npm run testandnpm run benchmarkand the Code of conduct