Refactored get_by_oauth_account on manager.py #1348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uthAccount on BaseUserDatabase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to handle missing of OuthAccount on BaseUserDatabase
I went through it not once, but twice. When implementing fastapiusers with OAuth, I forgot to add the 'OAuthAccount' class to the definition of 'BeanieUserDatabase(User, OAuthAccount)' or 'SQLAlchemyUserDatabase(session, User, OAuthAccount)' on db.py example file.
When that happens, the API works fine until the OAuth2 flow is initiated, and the error occurs without knowing exactly where. Perhaps this is a good way to catch the error and save hours of searching and digging into the code to solve the issue.
PS: Enjoy digging into the code.