Remove tiangolo.com from the CORS origin list#3
Closed
ferndot wants to merge 1 commit intofastapi:masterfastapi/full-stack-fastapi-template:masterfrom
ferndot:patch-1Copy head branch name to clipboard
Closed
Remove tiangolo.com from the CORS origin list#3ferndot wants to merge 1 commit intofastapi:masterfastapi/full-stack-fastapi-template:masterfrom ferndot:patch-1Copy head branch name to clipboard
ferndot wants to merge 1 commit intofastapi:masterfastapi/full-stack-fastapi-template:masterfrom
ferndot:patch-1Copy head branch name to clipboard
Conversation
This should not be enabled on every project unless tiangolo.com provides functionality necessary for the project to work.
Member
|
Yes, it provides functionatily for development. http://localhost.tiangolo.com points to your Both are local IPs. Having a domain pointing to them allows debugging certain things that are not easy to debug otherwise (like CORS configurations). |
Author
|
Thanks for clarifying! I should have looked deeper in the docs. |
Member
|
No problem, thanks for coming back and closing it 👍 |
|
@tiangolo Just out of curiosity. How have you setup those domains to point at localhost? I recently was trying to do something similar using route53 and couldn't get it to work. |
alejsdev
pushed a commit
that referenced
this pull request
Dec 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should not be enabled on every project unless tiangolo.com provides functionality necessary for the project to work.