fancyweb
diff --git a/‎src/Symfony/Bridge/Monolog/Handler/FirePHPHandler.php
Copy file name to clipboardExpand all lines: src/Symfony/Bridge/Monolog/Handler/FirePHPHandler.php
+1-1Lines changed: 1 addition & 1 deletion b/‎src/Symfony/Bridge/Monolog/Handler/FirePHPHandler.php
Copy file name to clipboardExpand all lines: src/Symfony/Bridge/Monolog/Handler/FirePHPHandler.php
+1-1Lines changed: 1 addition & 1 deletion
diff --git a/‎src/Symfony/Bridge/Monolog/Tests/Handler/FirePHPHandlerTest.php
Copy file name to clipboard
+40Lines changed: 40 additions & 0 deletions b/‎src/Symfony/Bridge/Monolog/Tests/Handler/FirePHPHandlerTest.php
Copy file name to clipboard
+40Lines changed: 40 additions & 0 deletions
@@ -41,7 +41,7 @@ public function onKernelResponse(ResponseEvent $event)
         }
 
         $request = $event->getRequest();
-        if (!preg_match('{\bFirePHP/\d+\.\d+\b}', $request->headers->get('User-Agent'))
+        if (!preg_match('{\bFirePHP/\d+\.\d+\b}', $request->headers->get('User-Agent', ''))
             && !$request->headers->has('X-FirePHP-Version')) {
             self::$sendHeaders = false;
             $this->headers = [];
 
@@ -0,0 +1,40 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Bridge\Monolog\Tests\Handler;
+
+use PHPUnit\Framework\TestCase;
+use Symfony\Bridge\Monolog\Handler\FirePHPHandler;
+use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
+use Symfony\Component\HttpKernel\Event\ResponseEvent;
+use Symfony\Component\HttpKernel\HttpKernelInterface;
+
+class FirePHPHandlerTest extends TestCase
+{
+    public function testOnKernelResponseShouldNotTriggerDeprecation()
+    {
+        $request = Request::create('/');
+        $request->headers->remove('User-Agent');
+
+        $response = new Response('foo');
+        $event = new ResponseEvent($this->createMock(HttpKernelInterface::class), $request, HttpKernelInterface::MAIN_REQUEST, $response);
+
+        $error = null;
+        set_error_handler(function ($type, $message) use (&$error) { $error = $message; }, \E_DEPRECATED);
+
+        $listener = new FirePHPHandler();
+        $listener->onKernelResponse($event);
+        restore_error_handler();
+
+        $this->assertNull($error);
+    }
+}
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public function onKernelResponse(ResponseEvent $event)`
`41`	`41`	`}`
`42`	`42`
`43`	`43`	`$request = $event->getRequest();`
`44`		`- if (!preg_match('{\bFirePHP/\d+\.\d+\b}', $request->headers->get('User-Agent'))`
	`44`	`+ if (!preg_match('{\bFirePHP/\d+\.\d+\b}', $request->headers->get('User-Agent', ''))`
`45`	`45`	`&& !$request->headers->has('X-FirePHP-Version')) {`
`46`	`46`	`self::$sendHeaders = false;`
`47`	`47`	`$this->headers = [];`