WIP towards Tomcat and Standalone support#14
Open
bmustiata wants to merge 4 commits intofakereplace:masterfakereplace/fakereplace:masterfrom
Open
WIP towards Tomcat and Standalone support#14bmustiata wants to merge 4 commits intofakereplace:masterfakereplace/fakereplace:masterfrom
bmustiata wants to merge 4 commits intofakereplace:masterfakereplace/fakereplace:masterfrom
Conversation
| return false; //lambdas | ||
| // if no packages are given, replace all classes. | ||
| if (replaceablePackages.length == 0) { | ||
| return true; |
Member
There was a problem hiding this comment.
I think this will cause problems. e.g. at the moment replacement for lambdas does not work properly so lambdas will break.
Member
|
Why did you go for .ini files rather than standard java property files (which would save a lot of code)? IMHO Java developers are a lot more familiar with property files, while .ini files are mostly a windows thing. e.g. something like |
df47b31 to
8ab7407
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
This is just so you can have a look at.
Important changes are:
Especially the 2nd point needs quite a bit of cleaning, since the monitoring was implemented by looping in a thread, and the ini reading has some issues. I've seen you have something in your Maven plugin that looks much cleaner for monitoring, I would probably borrow that.