Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat: random data for tables missing in yaml #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

andreasgangso
Copy link
Contributor

Thank you for creating this project!
I had a case where I wanted to automock the whole database, but needed to customize a few tables. This PR allows to do that by adding RandomDataForMissingTables: true to the yaml root.
Not thoroughly tested.

@faisaltheparttimecoder
Copy link
Owner

Hey @andreasgan , Thank you so much for the pull request, it looks good I will test it out and generate a testcase on it.

Quick question, was wondering would it be a better option to create all the table skeleton on a YAML and then let user pick to what he wants to customize or delete what he doesn't need ?.

i.e something like mock custom --create-plan-for-all-database

or this seems like a better option

@faisaltheparttimecoder
Copy link
Owner

I think yours might be better, since the YAML options would create a long list if there are too many tables ( and too many columns ) so navigating on it would be a pain.. I will test it out and approve it , thanks again @andreasgan

@andreasgangso
Copy link
Contributor Author

andreasgangso commented Oct 26, 2021

Adding --all-tables would not be a replacement for this, but its still a good idea.
Saves you from having to do `mock custom --tables a,b,c,d,e,f,g,h,i,...."

@faisaltheparttimecoder faisaltheparttimecoder merged commit c07fd43 into faisaltheparttimecoder:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.