Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Change type of Value prop #123

Copy link
Copy link
@alfonsogarciacaro

Description

@alfonsogarciacaro
Issue body actions

When using a select element that has Multiple true property, React forces us to pass a string array as Value, however this prop is currently typed as Value of string, which makes unboxing a needed (after the dev discover the error at runtime).

We have two solutions to fix this:

  • Make it obj as we have done for other items, I assume the runtime will automatically transform things as numbers to string, but it may not be the format they expect.
  • Make it U2<string, string[]>, which will break a lot of code forcing devs to add !^ everywhere.

What do you think? @MangelMaxime @nojaf

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Morty Proxy This is a proxified and sanitized view of the page, visit original site.