Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit e157ec0

Browse filesBrowse files
Lucme-no-dev
Luc
authored andcommitted
expose post args during upload (espressif#1650)
1 parent 05d72f9 commit e157ec0
Copy full SHA for e157ec0

File tree

Expand file treeCollapse file tree

3 files changed

+34
-11
lines changed
Filter options
Expand file treeCollapse file tree

3 files changed

+34
-11
lines changed

‎libraries/WebServer/src/Parsing.cpp

Copy file name to clipboardExpand all lines: libraries/WebServer/src/Parsing.cpp
+19-11Lines changed: 19 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,10 @@
3232
#define DEBUG_OUTPUT Serial
3333
#endif
3434

35+
#ifndef WEBSERVER_MAX_POST_ARGS
36+
#define WEBSERVER_MAX_POST_ARGS 32
37+
#endif
38+
3539
static const char Content_Type[] PROGMEM = "Content-Type";
3640
static const char filename[] PROGMEM = "filename";
3741

@@ -383,8 +387,9 @@ bool WebServer::_parseForm(WiFiClient& client, String boundary, uint32_t len){
383387
client.readStringUntil('\n');
384388
//start reading the form
385389
if (line == ("--"+boundary)){
386-
RequestArgument* postArgs = new RequestArgument[32];
387-
int postArgsLen = 0;
390+
if(_postArgs) delete[] _postArgs;
391+
_postArgs = new RequestArgument[WEBSERVER_MAX_POST_ARGS];
392+
_postArgsLen = 0;
388393
while(1){
389394
String argName;
390395
String argValue;
@@ -445,7 +450,7 @@ bool WebServer::_parseForm(WiFiClient& client, String boundary, uint32_t len){
445450
DEBUG_OUTPUT.println();
446451
#endif
447452

448-
RequestArgument& arg = postArgs[postArgsLen++];
453+
RequestArgument& arg = _postArgs[_postArgsLen++];
449454
arg.key = argName;
450455
arg.value = argValue;
451456

@@ -552,22 +557,25 @@ bool WebServer::_parseForm(WiFiClient& client, String boundary, uint32_t len){
552557
}
553558

554559
int iarg;
555-
int totalArgs = ((32 - postArgsLen) < _currentArgCount)?(32 - postArgsLen):_currentArgCount;
560+
int totalArgs = ((WEBSERVER_MAX_POST_ARGS - _postArgsLen) < _currentArgCount)?(WEBSERVER_MAX_POST_ARGS - _postArgsLen):_currentArgCount;
556561
for (iarg = 0; iarg < totalArgs; iarg++){
557-
RequestArgument& arg = postArgs[postArgsLen++];
562+
RequestArgument& arg = _postArgs[_postArgsLen++];
558563
arg.key = _currentArgs[iarg].key;
559564
arg.value = _currentArgs[iarg].value;
560565
}
561566
if (_currentArgs) delete[] _currentArgs;
562-
_currentArgs = new RequestArgument[postArgsLen];
563-
for (iarg = 0; iarg < postArgsLen; iarg++){
567+
_currentArgs = new RequestArgument[_postArgsLen];
568+
for (iarg = 0; iarg < _postArgsLen; iarg++){
564569
RequestArgument& arg = _currentArgs[iarg];
565-
arg.key = postArgs[iarg].key;
566-
arg.value = postArgs[iarg].value;
570+
arg.key = _postArgs[iarg].key;
571+
arg.value = _postArgs[iarg].value;
567572
}
568573
_currentArgCount = iarg;
569-
if (postArgs)
570-
delete[] postArgs;
574+
if (_postArgs) {
575+
delete[] _postArgs;
576+
_postArgs=nullptr;
577+
_postArgsLen = 0;
578+
}
571579
return true;
572580
}
573581
#ifdef DEBUG_ESP_HTTP_SERVER

‎libraries/WebServer/src/WebServer.cpp

Copy file name to clipboardExpand all lines: libraries/WebServer/src/WebServer.cpp
+12Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,8 @@ WebServer::WebServer(IPAddress addr, int port)
5454
, _lastHandler(nullptr)
5555
, _currentArgCount(0)
5656
, _currentArgs(nullptr)
57+
, _postArgsLen(0)
58+
, _postArgs(nullptr)
5759
, _headerKeysCount(0)
5860
, _currentHeaders(nullptr)
5961
, _contentLength(0)
@@ -72,6 +74,8 @@ WebServer::WebServer(int port)
7274
, _lastHandler(nullptr)
7375
, _currentArgCount(0)
7476
, _currentArgs(nullptr)
77+
, _postArgsLen(0)
78+
, _postArgs(nullptr)
7579
, _headerKeysCount(0)
7680
, _currentHeaders(nullptr)
7781
, _contentLength(0)
@@ -507,6 +511,10 @@ void WebServer::_streamFileCore(const size_t fileSize, const String & fileName,
507511

508512

509513
String WebServer::arg(String name) {
514+
for (int j = 0; j < _postArgsLen; ++j) {
515+
if ( _postArgs[j].key == name )
516+
return _postArgs[j].value;
517+
}
510518
for (int i = 0; i < _currentArgCount; ++i) {
511519
if ( _currentArgs[i].key == name )
512520
return _currentArgs[i].value;
@@ -531,6 +539,10 @@ int WebServer::args() {
531539
}
532540

533541
bool WebServer::hasArg(String name) {
542+
for (int j = 0; j < _postArgsLen; ++j) {
543+
if (_postArgs[j].key == name)
544+
return true;
545+
}
534546
for (int i = 0; i < _currentArgCount; ++i) {
535547
if (_currentArgs[i].key == name)
536548
return true;

‎libraries/WebServer/src/WebServer.h

Copy file name to clipboardExpand all lines: libraries/WebServer/src/WebServer.h
+3Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,9 @@ class WebServer
179179

180180
int _currentArgCount;
181181
RequestArgument* _currentArgs;
182+
int _postArgsLen;
183+
RequestArgument* _postArgs;
184+
182185
std::unique_ptr<HTTPUpload> _currentUpload;
183186

184187
int _headerKeysCount;

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.