Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Commit bb7907b

Browse filesBrowse files
committed
build: Node.js@18.10
closes #5014
1 parent f56ce73 commit bb7907b
Copy full SHA for bb7907b

File tree

Expand file treeCollapse file tree

3 files changed

+6
-5
lines changed
Open diff view settings
Filter options
Expand file treeCollapse file tree

3 files changed

+6
-5
lines changed
Open diff view settings
Collapse file

‎.github/workflows/ci.yml‎

Copy file name to clipboardExpand all lines: .github/workflows/ci.yml
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ jobs:
106106
node-version: "17.9"
107107

108108
- name: Node.js 18.x
109-
node-version: "18.7"
109+
node-version: "18.10"
110110

111111
steps:
112112
- uses: actions/checkout@v2
Collapse file

‎appveyor.yml‎

Copy file name to clipboardExpand all lines: appveyor.yml
+1-1Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ environment:
1919
- nodejs_version: "15.14"
2020
- nodejs_version: "16.17"
2121
- nodejs_version: "17.9"
22-
- nodejs_version: "18.7"
22+
- nodejs_version: "18.10"
2323
cache:
2424
- node_modules
2525
install:
Collapse file

‎test/res.sendFile.js‎

Copy file name to clipboardExpand all lines: test/res.sendFile.js
+4-3Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1050,12 +1050,13 @@ describe('res', function(){
10501050

10511051
app.use(function(req, res){
10521052
res.sendfile('test/fixtures/user.html', function(err){
1053-
assert(!res.headersSent);
1054-
assert.strictEqual(req.socket.listeners('error').length, 1) // node's original handler
1053+
assert.ok(err)
1054+
assert.ok(!res.headersSent)
1055+
assert.strictEqual(err.message, 'broken!')
10551056
done();
10561057
});
10571058

1058-
req.socket.emit('error', new Error('broken!'));
1059+
req.socket.destroy(new Error('broken!'))
10591060
});
10601061

10611062
request(app)

0 commit comments

Comments
0 (0)
Morty Proxy This is a proxified and sanitized view of the page, visit original site.