word-search: Update tests to version 1.1.0(#1012) #1053
Conversation
cmccandless
left a comment
There was a problem hiding this comment.
@wilson8507 I've left some comments, please address them.
| self.example.search('ecmascript'), | ||
| (Point(9, 0), Point(9, 9)) | ||
| ) | ||
| self.assertEqual( |
There was a problem hiding this comment.
There are a lot of redundant and misplaced assertions. Please check that each assertion actually belongs under its test method (Example: checks for "clojure" in self.example should only appear in tests for horizontal words).
- Delete assertions that appearing in multiple test methods - Make sure each test case appearing in correct test methods
…thon into update/word-search
|
@cmccandless I've fixed it, please check if there is any problem. Thanks! |
| from word_search import WordSearch, Point | ||
|
|
||
| # Tests adapted from `problem-specifications//canonical-data.json` @ v1.1.0 | ||
|
|
There was a problem hiding this comment.
Minor formatting point, but can you move the version comment down a line (ie. two blank lines before, one after).
N-Parsons
left a comment
There was a problem hiding this comment.
I've left a comment regarding a minor formatting issue. Once you've resolved it, I'm happy merge this.
Thanks for the hard work, @wilson8507!
- Move the version comment down a line
…thon into update/word-search
|
@N-Parsons I've resolved it. Thank you for pointing out my carelessness! |
|
Perfect! Thanks, @wilson8507! I'm a bit picky about formatting and consistency 😛 |
) * word-search: Update tests to version 1.1.0(exercism#1012) * Remove redundant and misplaced assertions
resolve issue #1012