Skip to content

Navigation Menu

Sign in

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Get DefaultTags from appSettings (#319) #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2025
Merged

Get DefaultTags from appSettings (#319) #320

merged 2 commits into from
Mar 31, 2025

Conversation

nmdias
Copy link
Contributor

@nmdias nmdias commented Mar 28, 2025

No description provided.

@CLAassistant
Copy link

CLAassistant commented Mar 28, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nmdias nmdias changed the title Get tags from appSettings #319 Get tags from appSettings Mar 29, 2025
niemyjski
niemyjski reviewed Mar 31, 2025
View reviewed changes
Copy link
Member

@niemyjski niemyjski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for thre PR, it looks good just need to get to concensus on the name of it!

My vote is DefaultTags as that aligns with IConfiguration but open to feedback cc @ejsmith .

@niemyjski niemyjski changed the title Get tags from appSettings Get tags from appSettings (#319) Mar 31, 2025
@niemyjski niemyjski self-assigned this Mar 31, 2025
@nmdias nmdias changed the title Get tags from appSettings (#319) Get DefaultTags from appSettings (#319) Mar 31, 2025
@nmdias
Copy link
Contributor Author

nmdias commented Mar 31, 2025

@niemyjski will be possible to get a release with this update? 🙏

@niemyjski
Copy link
Member

Yes, I'll get a release out this week. I just wanted to check in on a second issue I'm waiting to hear back on (#318)

@niemyjski niemyjski merged commit b4ffece into exceptionless:main Mar 31, 2025
4 checks passed
@nmdias
Copy link
Contributor Author

nmdias commented Mar 31, 2025

Super! Thanks :)

@niemyjski
Copy link
Member

niemyjski commented Apr 7, 2025 •
edited
Loading

New release is going out https://github.com/exceptionless/Exceptionless.Net/releases/tag/v6.1.0 , Thanks again

@nmdias
Copy link
Contributor Author

nmdias commented Apr 7, 2025

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ejsmith ejsmith ejsmith left review comments

@niemyjski niemyjski niemyjski approved these changes

Assignees

@niemyjski niemyjski

Labels
enhancement
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nmdias @CLAassistant @niemyjski @ejsmith
Morty Proxy This is a proxified and sanitized view of the page, visit original site.