-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Improvements for images (correct reading/writing possitions) #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| /** | ||
| * Copyright (c) 2018 Paweł Siemienik | ||
| * LICENCE: MIT - please refer to LICENCE file included with this module | ||
| * or https://github.com/guyonroche/exceljs/blob/master/LICENSE | ||
| */ | ||
|
|
||
| 'use strict'; | ||
|
|
||
| var Anchor = module.exports = function (model = {}) { | ||
| this.nativeCol = model.nativeCol || 0; | ||
| this.nativeColOff = model.nativeColOff || 0; | ||
| this.nativeRow = model.nativeRow || 0; | ||
| this.nativeRowOff = model.nativeRowOff || 0; | ||
|
|
||
| if (model.col) { | ||
| this.col = model.col; | ||
| } | ||
|
|
||
| if (model.row) { | ||
| this.row = model.row; | ||
| } | ||
| }; | ||
|
|
||
| Anchor.asInstance = function (model) { | ||
| return model instanceof Anchor || model == null ? model : new Anchor(model); | ||
| }; | ||
|
|
||
| Anchor.prototype = { | ||
| worksheet: null, | ||
| get col() { | ||
| return this.nativeCol + Math.min(this.colWidth - 1, this.nativeColOff) / this.colWidth; | ||
| }, | ||
| set col(v) { | ||
| if (v === this.col) return; | ||
| this.nativeCol = Math.floor(v); | ||
| this.nativeColOff = Math.floor((v - this.nativeCol) * this.colWidth); | ||
| }, | ||
| get row() { | ||
| return this.nativeRow + Math.min(this.rowHeight - 1, this.nativeRowOff) / this.rowHeight; | ||
| }, | ||
| set row(v) { | ||
| if (v === this.row) return; | ||
| this.nativeRow = Math.floor(v); | ||
| this.nativeRowOff = Math.floor((v - this.nativeRow) * this.rowHeight); | ||
| }, | ||
| get colWidth() { | ||
| return this.worksheet && this.worksheet.getColumn(this.nativeCol + 1) && this.worksheet.getColumn(this.nativeCol + 1).isCustomWidth ? | ||
| Math.floor(this.worksheet.getColumn(this.nativeCol + 1).width * 10000) : | ||
| 640000; | ||
| }, | ||
| get rowHeight() { | ||
| return this.worksheet && this.worksheet.getRow(this.nativeRow + 1) && this.worksheet.getRow(this.nativeRow + 1).height ? | ||
| Math.floor(this.worksheet.getRow(this.nativeRow + 1).height * 10000) : | ||
| 180000; | ||
| } | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I think this shouldn't be in individual files
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alubbe In each file is copyright/author block similar to this, if it's wrong could you write how it should looks like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah indeed - I had completely missed that. Let's leave that in then.
@guyonroche I've only seen licenses repeated in every file if you want to charge license fees for your IP, but since we use MIT I think there's no need to have this repeated everywhere - it's just noise that needs maintenance. Would you be okay with removing them everywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alubbe Yeah - We could probably get away with just the LICENCE file with links from the README.md and main excel.js file.
I finally have more spare time now so I can start working through the PRs. I'll test this one tomorrow morning