Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@kendallroth
Copy link
Contributor

The previous examples for merging cells by row/column numbers were confusing and didn't actually describe what parameters the function was expecting. The example made it appear that mergeCells(10, 11, 12, 13) was the same as mergeCells("G10", "H11"), which is not the case. This example has been updated as well as another comment added.

The previous examples for merging cells by row/column numbers were confusing and didn't actually describe what parameters the function was expecting. The example made it appear that `mergeCells(10, 11, 12, 13)` was the same as `mergeCells("G10", "H11")`, which is not the case. This example has been updated as well as another comment added.
@Siemienik
Copy link
Member

Siemienik commented Jan 11, 2020

for me, both versions are clear to understand.
If I have to choose one, I'll prefer "top-left-bottom-right" - it's easier to remember :)

@guyonroche guyonroche merged commit 94f2f7a into exceljs:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.