SSL: supporting async connection establishment#20
Open
dorszman wants to merge 1 commit intoevdb:masterevdb/HTTP-Async:masterfrom
dorszman:ssl_async_connectiondorszman/HTTP-Async:ssl_async_connectionCopy head branch name to clipboard
Open
SSL: supporting async connection establishment#20dorszman wants to merge 1 commit intoevdb:masterevdb/HTTP-Async:masterfrom dorszman:ssl_async_connectiondorszman/HTTP-Async:ssl_async_connectionCopy head branch name to clipboard
dorszman wants to merge 1 commit intoevdb:masterevdb/HTTP-Async:masterfrom
dorszman:ssl_async_connectiondorszman/HTTP-Async:ssl_async_connectionCopy head branch name to clipboard
Conversation
|
I am in the process of taking over this project, and I apologize for how long this pull request has gone without response. This pull request breaks for non-SSL requests:
Also on a server that never accepts on the incoming socket, this change removes the (timeout-long) delay on Given the delay in responding, are you still interested in working on this pull request and fixing these issues? If not, do you have any objection for me using this as a starting point? |
Author
|
a
Dear Andrea I am very happy to hear someone is interested and may benefit
from my code. Please feel free to start from this point. it will be
appreciated if you mention somehow my name (Doron Cohen) but this is not a
mandatory.
Doron
…On Tue, Jun 4, 2019, 1:48 AM Andrea Nall ***@***.***> wrote:
I am in the process of taking over this project, and I apologize for how
long this pull request has gone without response.
This pull request breaks for non-SSL requests:
Can't locate object method "connect_SSL" via package "Net::HTTP::NB" at
lib/HTTP/Async.pm line 940.
Also on a server that never accepts on the incoming socket, this change
removes the (timeout-long) delay on add, but also does not seem to
respect the timeout on wait_for_next_response. The timeout is respected
in wait_for_next_response on HTTP requests w/o your commit.
Given the delay in responding, are you still interested in working on this
pull request and fixing these issues? If not, do you have any objection for
me using this as a starting point?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#20?email_source=notifications&email_token=AI342AXD4IJ6ENQBQB73K4TPYWNS7A5CNFSM4EUQ5U22YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW246KA#issuecomment-498454312>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AI342AREKT4EKCQ4JPU4GX3PYWNS7ANCNFSM4EUQ5U2Q>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSL connection handshake is not async, as a result calling add() to initiate a new https request results in blocking till ssl connection is fully established. This may take a couple of hundreds of ms.
The proposed fix - make ssl connection fully async and non-blocking.