Java installation process enhancements#20
Merged
Java installation process enhancements#20
Conversation
Member
|
Hi @JakubVanek Is it possible if we merge this positive change in the next release? Once we start the new iteration, I will merge on develop. Is it ok for you? Juan Antonio |
Contributor
Author
|
It might be OK for me, but the previous update code is broken. if type -p java; then
echo "Found java executable in PATH"
JAVA_REAL_EXE="$(which java)"
if [ ! -d "$JRI_OPT/jri-10-build-050" ]; then
echo "But we will upgrade the Java version"
echo $JRI_OPT/jri-10-build-050
echo
if [ "$PLATFORM" == "ev3" ]; then
java_install_bundle
elif [ "$PLATFORM" == "brickpi" ] ||
[ "$PLATFORM" == "brickpi3" ] ||
[ "$PLATFORM" == "pistorms" ]; then
java_install_ppa
fi
else
echo "Latest Java installed."
echo $JRI_OPT/jri-10-build-050
fi
elif ...We don't have |
Contributor
Author
|
This is another instance of broken code -- we're saying we're going to update, but nothing will happen. elif [[ -n "$JAVA_HOME" ]] && [[ -x "$JAVA_HOME/bin/java" ]]; then
echo "Found java executable in JAVA_HOME"
JAVA_REAL_EXE="$JAVA_HOME/bin/java"
echo $JRI_OPT/jri-10-build-050
if [ ! -d "$JRI_OPT/jri-10-build-050" ]; then
echo "But upgrading Java version"
echo
fi
else |
Contributor
Author
|
I should've described what this patch does in more detail than "some enhancement", I'm sorry for that. |
Member
|
Oki, tomorrow, I will merge. :) |
Member
|
I will remove previous installation and I will tomorrow. |
Member
|
Merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Future possible improvements: