Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Implement EIP-7825 for osaka (wip) #4073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 7 commits into
base: master
Choose a base branch
Loading
from
Draft

Implement EIP-7825 for osaka (wip) #4073

wants to merge 7 commits into from

Conversation

ScottyPoi
Copy link
Contributor

@ScottyPoi ScottyPoi commented May 8, 2025

Implement EIP-7825: Transaction Gas Limit Cap

Description

This PR implements EIP-7825, which introduces a protocol-level cap on the maximum gas used by a transaction to 30 million gas. This cap is independent of the block gas limit and applies to all transaction types.

Changes

  1. Added EIP-7825 parameter in packages/tx/src/params.ts:

    • Added maxTransactionGasLimit parameter set to 30 million gas
  2. Added validation in packages/tx/src/util/internal.ts:

    • Added check in sharedConstructor to validate transaction gas limit against EIP-7825 cap
    • Throws error if gas limit exceeds 30 million gas when EIP-7825 is activated
  3. Added validation in packages/client/src/service/txpool.ts:

    • Added check in validate method to ensure transactions don't exceed EIP-7825 gas limit cap
    • Rejects transactions with gas limit over 30 million when EIP-7825 is activated

TODO:

Tests

Copy link

codecov bot commented May 8, 2025

Codecov Report

Attention: Patch coverage is 48.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 79.38%. Comparing base (5eaf56a) to head (666aa4e).

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 84.33% <ø> (ø)
blockchain 89.32% <ø> (ø)
client 67.55% <12.50%> (-0.03%) ⬇️
common 97.51% <100.00%> (+<0.01%) ⬆️
devp2p 86.78% <ø> (ø)
evm 73.11% <100.00%> (ø)
mpt 89.74% <ø> (ø)
statemanager 69.06% <ø> (ø)
static 99.11% <ø> (ø)
tx 89.66% <45.45%> (-0.23%) ⬇️
util 89.20% <100.00%> (+0.01%) ⬆️
vm 55.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.