Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

go.mod: add tool section in module file #32598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fjl merged 1 commit into from
Sep 15, 2025
Merged

go.mod: add tool section in module file #32598

fjl merged 1 commit into from
Sep 15, 2025

Conversation

@markya0616
Copy link
Contributor

@markya0616 markya0616 commented Sep 12, 2025

Summary

This PR switches tool management to use go get -tool.

Details

According to go help get:

The -tool flag instructs go to add a matching tool line to go.mod for each
listed package. If -tool is used with @none, the line will be removed.

Example

To update go.mod and remove build/tools, run:

go get -tool google.golang.org/protobuf/cmd/protoc-gen-go@v1.34.2
go get -tool golang.org/x/tools/cmd/stringer@v0.29.0
go get -tool github.com/fjl/gencodec@v0.1.0

@fjl fjl self-assigned this Sep 12, 2025
@fjl fjl changed the title go.mod, build/tools: use go get -tool to set tools go.mod: use go get -tool to set tools Sep 15, 2025
@fjl fjl changed the title go.mod: use go get -tool to set tools go.mod: add tool section in module file Sep 15, 2025
@fjl fjl added this to the 1.16.4 milestone Sep 15, 2025
@fjl fjl merged commit 89f364f into ethereum:master Sep 15, 2025
7 of 8 checks passed
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 16, 2025
@gzliudan
go.mod: add tool section in module file ethereum#32598
5bfa35f
@gzliudan gzliudan mentioned this pull request Sep 16, 2025
Merged
19 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 17, 2025
@gzliudan
go.mod: add tool section in module file ethereum#32598
55fa4af
gzliudan added a commit to XinFinOrg/XDPoSChain that referenced this pull request Sep 21, 2025
@gzliudan
go.mod: add tool section in module file ethereum#32598 (#1513)
185e28a
Sahil-4555 pushed a commit to Sahil-4555/go-ethereum that referenced this pull request Oct 12, 2025
@markya0616 @Sahil-4555
go.mod: add tool section in module file (ethereum#32598)
c7ff9d9 
This removes the tools.go workaround in favor of the official
tool management infrastructure, which was added in Go 1.24.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@fjl fjl

Labels

None yet

Projects

None yet

Milestone

1.16.4

Development

Successfully merging this pull request may close these issues.

2 participants

@markya0616 @fjl
Morty Proxy This is a proxified and sanitized view of the page, visit original site.