Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

fix(t8n): include system contracts in alloc for besu generated state tests #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
Loading
from

Conversation

danceratopz
Copy link
Member

🗒️ Description

This change includes the pre_allocation_blockchain() for the fork in the pre-alloc for the state_test format for the Besu t8n tool (evmtool). See related issues.

If the system contracts aren't present, then filing fails with an error similar to:

    transition_tool_output = t8n.evaluate(
src/ethereum_clis/clis/besu.py:166: in evaluate
    response.raise_for_status()  # exception visible in pytest failure output
.venv/lib/pypy3.10/site-packages/requests/models.py:1024: in raise_for_status
    raise HTTPError(http_error_msg, response=self)
E   requests.exceptions.HTTPError: 500 Server Error: Internal Server Error for url: http://localhost:34805/

This is a funny one, as the generated state_test fixtures won't pass when executed against any other clients, so I'm not sure if we should include it. But perhaps the commit is useful to the Besu Team while trying to fill Osaka tests.

🔗 Related Issues

These seem to be the changes that broke fill:

from:

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@danceratopz danceratopz self-assigned this May 20, 2025
@danceratopz danceratopz added type:bug Something isn't working needs-discussion Needs discussion before proceeding scope:cli Scope: Changes to `ethereum_clis` labels May 20, 2025
@danceratopz danceratopz requested a review from marioevz May 20, 2025 21:06
@marioevz
Copy link
Member

I don't think we should merge this.

Without this, the worst case is that besu can only be used to fill blockchain tests, which for the most part is good enough.

If we add this, it means that we generate state tests but they are incompatible with any other state test consumer, even Besu perhaps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-discussion Needs discussion before proceeding scope:cli Scope: Changes to `ethereum_clis` type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.