Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

feat(tests): eip-5920 pay opcode cases #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
Loading
from

Conversation

spencer-tb
Copy link
Contributor

🗒️ Description

Assumes that EIP-5920 will be in Osaka.

Uses a temp EELS resolution to fill:

Still a WIP.

Rebased on #1507 hence requires it.

🔗 Related Issues

N/A

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.

@spencer-tb spencer-tb added scope:tests Scope: Changes EL client test cases in `./tests` scope:fill Scope: fill command feature:eof type:feat type: Feature fork:osaka Osaka hardfork and removed scope:fill Scope: fill command feature:eof labels May 9, 2025
@jochem-brouwer
Copy link
Member

Linking for completeness: ethereum/EIPs#9590

@gurukamath
Copy link
Contributor

Just want to highlight the following

  • A new EELS PR with EIP-5920 implementation for Osaka is up

  • I would like to add the following to the list of relevant test cases

    • Trying to transfer non-zero value in static context
    • Trying to transfer zero value in static context
    • Trying to transfer zero value to a non-existent account
    • Trying to transfer higher value than the balance to a non-existent account

@jochem-brouwer
Copy link
Member

jochem-brouwer commented May 17, 2025

Wanted to drop a quick note here from the EIP (this has been in there for a long time):

PAY cannot be implemented on networks with empty accounts (see EIP-7523).

This is nice, because it means we don't have to deal with "touched" accounts and cleaning up the whole mess a la EIP-161. And this thus saves us rather big and nasty test situations.

The only thing we should strictly check though (in a simple test) is that if you PAY with 0 that if this gets used on a non-existing account, it will also leave it as non-existing account (and thus not leave an empty account in the trie).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fork:osaka Osaka hardfork scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.