Refactor how antithesis client can be configured #20736
Conversation
Signed-off-by: Nont <nont@duck.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nwnt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 30 files with indirect coverage changes @@ Coverage Diff @@
## main #20736 +/- ##
==========================================
+ Coverage 68.80% 69.15% +0.35%
==========================================
Files 418 420 +2
Lines 34707 34817 +110
==========================================
+ Hits 23879 24079 +200
+ Misses 9435 9341 -94
- Partials 1393 1397 +4 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@nwnt: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I'm unable to follow all the changes happening here. I don't consider it as refactor as it changes logic, there are so many variables changing at the same time that I'm unable to follow. Do we really need to rewrite everything at once? |
|
I think this is too big, but the goal is to move all the configs to the environment variables (i.e. standardizing them) instead of calculating them at the start of drivers or configuring it during the client build. I'm having this out based on the discussion here. By the way, the existing |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There are a lot of hardcoded or fixed configurations of the client for its etcd endpoints and where to find the etcd data files. The current configuration works for static test environment like docker-compose, but is a challenge for configuring in a more dynamic environment like k8s (explained a bit here).
This PR refactors the configurations so that they are configured via environment variables instead.
@serathius